[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] master 3716921: Portcheck only if --enable-gcc-warnings
From: |
Paul Eggert |
Subject: |
[Emacs-diffs] master 3716921: Portcheck only if --enable-gcc-warnings |
Date: |
Mon, 21 Oct 2019 20:33:24 -0400 (EDT) |
branch: master
commit 3716921c012d7b21a9b0d593a7ea0ddd1e860cfd
Author: Paul Eggert <address@hidden>
Commit: Paul Eggert <address@hidden>
Portcheck only if --enable-gcc-warnings
Problem reported by Richard Copley (Bug#37852).
This patch causes the problem to not occur if one uses plain
‘configure’. The problem can still occur if with ‘configure
--enable-gcc-warnings’, so a further fix may be needed.
* configure.ac (GNULIB_PORTCHECK, _FORTIFY_SOURCE):
Define these only with an explicit --enable-gcc-warnings.
---
configure.ac | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/configure.ac b/configure.ac
index 33d725c..3b6a2a6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1114,15 +1114,16 @@ AS_IF([test $gl_gcc_warnings = no],
fi
AC_DEFINE([GCC_LINT], [1], [Define to 1 if --enable-gcc-warnings.])
- AC_DEFINE([GNULIB_PORTCHECK], [1], [enable some gnulib portability checks])
- AH_VERBATIM([GNULIB_PORTCHECK_FORTIFY_SOURCE],
- [/* Enable compile-time and run-time bounds-checking, and some warnings,
- without upsetting glibc 2.15+. */
- #if (defined GNULIB_PORTCHECK && !defined _FORTIFY_SOURCE \
- && defined __OPTIMIZE__ && __OPTIMIZE__)
- # define _FORTIFY_SOURCE 2
- #endif
- ])
+ AS_IF([test $gl_gcc_warnings = yes],
+ [AC_DEFINE([GNULIB_PORTCHECK], [1], [enable some gnulib portability
checks])
+ AH_VERBATIM([GNULIB_PORTCHECK_FORTIFY_SOURCE],
+ [/* Enable compile-time and run-time bounds-checking, and some warnings,
+ without upsetting glibc 2.15+. */
+ #if (defined GNULIB_PORTCHECK && !defined _FORTIFY_SOURCE \
+ && defined __OPTIMIZE__ && __OPTIMIZE__)
+ # define _FORTIFY_SOURCE 2
+ #endif
+ ])])
])
# clang is picky about these regardless of whether
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] master 3716921: Portcheck only if --enable-gcc-warnings,
Paul Eggert <=