emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 721035d: * lisp/frameset.el (frameset--minibufferle


From: Juri Linkov
Subject: [Emacs-diffs] master 721035d: * lisp/frameset.el (frameset--minibufferless-last-p): Add comments (bug#36894)
Date: Fri, 9 Aug 2019 14:09:01 -0400 (EDT)

branch: master
commit 721035d61c88967fe1f8f24c3c4a10f4b6237326
Author: Juri Linkov <address@hidden>
Commit: Juri Linkov <address@hidden>

    * lisp/frameset.el (frameset--minibufferless-last-p): Add comments 
(bug#36894)
---
 lisp/frameset.el | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/lisp/frameset.el b/lisp/frameset.el
index a8b1670..60b6fe3 100644
--- a/lisp/frameset.el
+++ b/lisp/frameset.el
@@ -1104,9 +1104,18 @@ It sorts minibuffer-owning frames before minibufferless 
ones.
 Internal use only."
   (pcase-let ((`(,hasmini1 . ,id-def1) (cdr (assq 'frameset--mini (car 
state1))))
              (`(,hasmini2 . ,id-def2) (cdr (assq 'frameset--mini (car 
state2)))))
-    (cond ((eq id-def1 t) t)
+    ;; hasmini1 is t when 1st frame has its own minibuffer
+    ;; hasmini2 is t when 2nd frame has its own minibuffer
+    ;; id-def1 is t when 1st minibuffer-owning frame is the 
default-minibuffer-frame
+    ;;         or frame-id of 1st frame if it's minibufferless
+    ;; id-def2 is t when 2nd minibuffer-owning frame is the 
default-minibuffer-frame
+    ;;         or frame-id of 2nd frame if it's minibufferless
+    (cond ;; Sort the minibuffer-owning default-minibuffer-frame first
+         ((eq id-def1 t) t)
          ((eq id-def2 t) nil)
-         ((not (eq hasmini1 hasmini2)) (eq hasmini1 t))
+         ;; Sort non-default minibuffer-owning frames before minibufferless
+         ((not (eq hasmini1 hasmini2)) (eq hasmini1 t)) ;; boolean xor
+         ;; Sort minibufferless frames with frame-id before some remaining
          ((eq hasmini1 nil) (or id-def1 id-def2))
          (t t))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]