[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] emacs-26 5235eaf 25/39: Treat Flymake errors as just anoth
From: |
João Távora |
Subject: |
[Emacs-diffs] emacs-26 5235eaf 25/39: Treat Flymake errors as just another type of diagnostic |
Date: |
Tue, 3 Oct 2017 10:04:51 -0400 (EDT) |
branch: emacs-26
commit 5235eaf7816167143b5fef66e5c1acce569c4f61
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>
Treat Flymake errors as just another type of diagnostic
* lisp/progmodes/flymake.el (flymake--diag-errorp): Remove.
(flymake--handle-report, flymake-popup-current-error-menu):
Don't use it.
---
lisp/progmodes/flymake.el | 24 +++++++-----------------
1 file changed, 7 insertions(+), 17 deletions(-)
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 285ef93..0071ba9 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -401,13 +401,6 @@ associated `flymake-category' return DEFAULT."
(t
default))))
-(defun flymake--diag-errorp (diag)
- "Tell if DIAG is a flymake error or something else"
- (let ((sev (flymake--lookup-type-property 'severity
- (flymake--diag-type diag)
- (warning-numeric-level :error))))
- (>= sev (warning-numeric-level :error))))
-
(defun flymake--fringe-overlay-spec (bitmap)
(and flymake-fringe-indicator-position
bitmap
@@ -495,10 +488,9 @@ associated `flymake-category' return DEFAULT."
(list 'mouse-1 (posn-at-point))))
(diagnostics (mapcar (lambda (ov) (overlay-get ov
'flymake--diagnostic))
diag-overlays))
- (title (format "Line %d: %d error(s), %d other(s)"
+ (title (format "Line %d: %d diagnostics(s)"
(line-number-at-pos)
- (cl-count-if #'flymake--diag-errorp diagnostics)
- (cl-count-if-not #'flymake--diag-errorp diagnostics)))
+ (length diagnostics)))
(choice (x-popup-menu event (list title (cons "" menu)))))
(flymake-log :debug "choice=%s" choice)
;; FIXME: What is the point of going to the problem locus if we're
@@ -560,13 +552,11 @@ FORCE says to handle a report even if it was not
expected."
(flymake--highlight-line diag)
(setf (flymake--diag-backend diag) backend))
diagnostics)
- (let ((err-count (cl-count-if #'flymake--diag-errorp diagnostics))
- (warn-count (cl-count-if-not #'flymake--diag-errorp
- diagnostics)))
- (when flymake-check-start-time
- (flymake-log 2 "%d error(s), %d other(s) in %.2f second(s)"
- err-count warn-count
- (- (float-time) flymake-check-start-time)))))))
+ (when flymake-check-start-time
+ (flymake-log 2 "backend %s reported %d diagnostics in %.2f second(s)"
+ backend
+ (length diagnostics)
+ (- (float-time) flymake-check-start-time))))))
(t
(flymake--disable-backend "?"
:strange
- [Emacs-diffs] emacs-26 491cc4a 13/39: Flymake checks file names before considering diagnostics, (continued)
- [Emacs-diffs] emacs-26 491cc4a 13/39: Flymake checks file names before considering diagnostics, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 7787988 10/39: Flymake warning face easier to distinguish, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 5ec7d73 19/39: Flymake's flymake-proc.el backend slightly easier to debug, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 9a629a7 23/39: Add interactive flymake-start function, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 b0bb181 15/39: Protect Flymake's eager checks against commands like fill-paragraph, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 b2f8b8b 16/39: More Flymake cleanup before advancing to backend redesign, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 22a7372 31/39: Flymake uses proper idle timers, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 87993cd 28/39: Explicitly add a(n empty) keymap for Flymake, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 bb8b663 04/39: Move symbols in flymake-proc.el to separate namespace, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 483f1e8 22/39: A couple of Flymake backends for emacs-lisp-mode, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 5235eaf 25/39: Treat Flymake errors as just another type of diagnostic,
João Távora <=
- [Emacs-diffs] emacs-26 8118f0f 24/39: Fix three Flymake bugs when checking C header files, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 e0df7b9 21/39: Fancy Flymake mode-line construct displays status, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 cd39edb 26/39: Remove old flymake-display-err-menu-for-current-line, it's useless, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 2e84179 34/39: Tweak Flymake autoloads and dependencies, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 7360178 20/39: Tweak Flymake commands flymake-goto-[next/prev]-error, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 1b271ad 27/39: Flymake uses some new fringe bitmaps, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 94a88c1 17/39: New Flymake API variable flymake-diagnostic-functions, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 5d922e5 38/39: Start rewriting Flymake manual, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 fe9dc7a 01/39: Split Flymake into flymake.el into flymake-proc.el (again!), João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 30ea272 35/39: Hook Flymake onto proper checkdoc and byte-compile interfaces, João Távora, 2017/10/03