[Emacs-diffs] Changes to emacs/lisp/mail/smtpmail.el

[Simon Josefsson]

Index: emacs/lisp/mail/smtpmail.el
diff -u emacs/lisp/mail/smtpmail.el:1.81 emacs/lisp/mail/smtpmail.el:1.82
--- emacs/lisp/mail/smtpmail.el:1.81    Wed Dec 28 08:45:53 2005
+++ emacs/lisp/mail/smtpmail.el Tue Jan 10 14:06:14 2006
@@ -1,6 +1,6 @@
 ;;; smtpmail.el --- simple SMTP protocol (RFC 821) for sending mail
 
-;; Copyright (C) 1995, 1996, 2001, 2002, 2003, 2004, 2005
+;; Copyright (C) 1995, 1996, 2001, 2002, 2003, 2004, 2005, 2006
 ;;   Free Software Foundation, Inc.
 
 ;; Author: Tomoji Kagatani <address@hidden>
@@ -560,6 +560,11 @@
                (>= (car ret) 400))
            (throw 'done nil)))
        ((eq mech 'plain)
+       ;; We used to send an empty initial request, and wait for an
+       ;; empty response, and then send the password, but this
+       ;; violate a SHOULD in RFC 2222 paragraph 5.1.  Note that this
+       ;; is not sent if the server did not advertise AUTH PLAIN in
+       ;; the EHLO response.  See RFC 2554 for more info.
        (smtpmail-send-command process
                               (concat "AUTH PLAIN "
                                       (base64-encode-string