Re: autorevert-tail-truncate proposed for Emacs 31 and/or ELPA

[Ship Mints]

I'd just removed the :version tags as I felt they were presumptuous at this time. I'll restore them as "31.1" if this package is agreed to merge as part of autorevert.el proper.

I will change the commentary to say "for" instead of "extend".

I think suppressing vc-refresh-state in tailed buffers is a good idea, hence the control that people can put in their hooks on a buffer-local basis for this mode. If this behavior is made the default, there might be some wacky reason to have it be optional, but I can't imagine one.

Thank you for the thoughtful feedback, Michael.

-Stephane

On Tue, Feb 4, 2025 at 5:39 AM Michael Albinus <michael.albinus@gmx.de> wrote:

Ship Mints <shipmints@gmail.com> writes:

Hi Ship,

> I welcome thoughtful feedback.

Thanks for the package. I haven't tested it (yet). Just some few
comments after cursary reading:

> ;; Copyright (C) 2025 Stephane Marks
> ;; Copyright (C) 2025 Free Software Foundation, Inc.

In core Emacs, files are copyrighted to the FSF only. Usually.

> ;;; Commentary:
>
> ;; `auto-revert-tail-truncate-mode' extends `auto-revert-tail-mode' to

Perhaps you say explicitly, that it is a minor-mode which is intended
for `auto-revert-tail-mode'.

> (defcustom auto-revert-tail-truncate-max-lines 5000
>   "Truncate buffer to this maximum number of lines.
> If nil, truncation is disabled.  Bind this as a buffer-local variable to
> control the maximum number lines to retain for specific buffers."
>   :group 'auto-revert
>   :type 'natnum)

Pleae add a :version tag. If nil is allowed, you shall specify it in the
:type.

> (defcustom auto-revert-tail-truncate-file-size-hint 64
>   :group 'auto-revert
>   :type 'natnum)

Pleae add a :version tag.

> (defcustom auto-revert-tail-truncate-revert-interval auto-revert-interval
> (defcustom auto-revert-tail-truncate-verbose auto-revert-verbose
> (defcustom auto-revert-tail-truncate-immediately t
> (defcustom auto-revert-tail-truncate-read-only t
> (defcustom auto-revert-tail-truncate-disable-undo t
> (defcustom auto-revert-tail-truncate-disable-font-lock t
> (defcustom auto-revert-tail-truncate-check-vc-info auto-revert-check-vc-info
> (defcustom auto-revert-tail-truncate-mode-text " TailTrunc"

Dito.

I'm asking myself, whether we need
auto-revert-tail-truncate-check-vc-info here. Rather we shall suppress
the call of vc-refresh-state in auto-revert-tail-mode buffers at all. To
be changed in autorevert.el.

> -Stephane

Best regards, Michael.