Re: Should text-scale trigger hooks?

[James Cherti]

I tested adding a function to `text-scale-mode-hook` that executes:
(run-hooks 'window-configuration-change-hook)

And it solved the issue in both packages (`eat` and `visual-fill-column`).

After further consideration, I believe that this is not an Emacs core 
issue, but rather a problem caused by the implementation of those 
packages. It doesn't make sense for text scaling to run the 
window-configuration-change-hook functions.

--
James Cherti
https://www.jamescherti.com/

On 2024-11-07 04:42, Joost Kremers wrote:
> On Thu, Nov 07 2024, Eli Zaretskii wrote:
> > The need for adjusting the margins in this case is specific to how the
> > visual-fill-column package uses the margins, it is not a general need.
>
> Yes, true.
>
> > What are the problems of using text-scale-mode-hook?  Or even using
> > add-variable-watcher to cause Emacs call your function when
> > face-remapping-alist changes?
>
> I haven't actually tried those methods, since I rarely use
> text-scale-adjust and James's is the first user request I received about it
> in a long time.
>
> > IOW, why do you think this is a core Emacs issue, not an issue with
> > how visual-fill-column is implemented?
>
> Reading your message, I'm not sure that it is. But I guess this is also a
> question for James.