Re: [NonGNU ELPA] new package: clangd-inactive-regions

[Gerd Möllmann]

Filippo Argiolas <filippo.argiolas@gmail.com> writes:

> On Sat, Nov 2, 2024 at 10:13 AM Gerd Möllmann <gerd.moellmann@gmail.com> 
> wrote:
>> Works fine for me on macOS 15.1/tty with clangd 19.1 from Homebrew.
>> Thanks, that's a nice feature!
>>
>> You said you are interested in feedback, so here's my wishlist :-).
>>
>> - I'd preferred a global minor mode to turn this on and off.
>>   Which would replace the manual adding to the Eglot hook.
>
> Thanks for the very welcome feedback!
> My idea was to keep this local as it hooks into fontification and
> wanted to limit any problems that may arise only to the buffers where
> the mode is enabled.
> This by the way was only possible with c-ts-mode as cc-mode chains
> into the default function in its fontify-region hook, so if I want to
> run my code after theirs it must be inherently global.
>
> Guess the same could be achieved by defining a global minor mode and
> adding eglot/c mode hooks myself but I'd like to leave the control to
> the user for now.

Hm, okay.

>
>> - I think something is to be up with the faces? If I remove
>>
>>   (clangd-inactive-regions-set-method "darken-foreground")
>>   (clangd-inactive-regions-set-opacity 0.55))
>>
>>   the inactive regions are not shown, I think. If I put them in, they
>>   are.
>
> Thanks, always had those in the init and never noticed. Should be
> fixed now, could you test again?

Yes, it works now.