[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adding new package hideshowvis to nongnu elpa
From: |
Jan Rehders |
Subject: |
Re: Adding new package hideshowvis to nongnu elpa |
Date: |
Wed, 29 May 2024 13:35:04 +0200 |
I’ve applied your improvements, thank you!
> Are you sure you don't want the package to be added to GNU ELPA?
If that requires copyright assignment then I’m happy to do that but maybe at a
later time. I’m not sure I have the time+energy to do that and check if any
contributors submitted more than a few lines right now
> (defun hideshowvis-remove-overlays ()
> "Will remove all overlays added after calling `hideshowvis-symbols'."
> - (when (equal hs-set-up-overlay 'hideshowvis-display-code-line-counts)
> + (when (eq hs-set-up-overlay #'hideshowvis-display-code-line-counts)
> (dolist (ov (overlays-in (point-min) (point-max)))
> - (unless (null (overlay-get ov 'hs))
> + (when (overlay-get ov 'hs) ;why are you returning a `hs' here?
> (overlay-put ov 'after-string nil)))))
Not sure I understand the question - I don’t intend to return anything. I’m
using the ‘hs property added by hideshow.el to identify which overlays need to
be changed to not break other highlighting packages.
> You can track files to ignore in a .elpaignore file as well. That might
> be better, in case you decide to replace, rename the file or add more.
> I can change that for you, you just have to add the file to the
> repository.
This seems like a good idea, added .elpaignore to the repo