Re: MPS: Please check if scratch/igc builds with native compilation

[Andrea Corallo]

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>
>> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>>
>>> Or something completely different, I actually have no idea :-).
>>
>> I came to one conclusion this afternoon nemely that fix_comp_unit is
>> 100% wrong: it may not scan d_reloc etc. in the shared object
>> because there is no synchronization between threads reading/writing
>> these.
>>
>> Remains the question why making them roots did not work for me. A root
>> ensures synchronization by stopping the world while roots are scanned.
>>
>> I guess I'll have to double check if that was really the same error as
>> w/o roots, or if it only looked like it was.
>
> I've now pushed something.
>
> This doesn't make the native comp build work, but the errors are
> different, and in the cases of IGC_OBJ_FWD assertions I think these
> don't have the same cause, at least they don't follow the patterns I've
> previously seen in LLDB.
>
> In summary, I think this is an improvement.
>
> Could anyone (of the currently n = 3 people reporting back
> (not disappointing because expected) try this?

Hi Gerd,

on I 2bd8ee79d93 I get:

igc.c:2189: Emacs fatal error: assertion failed: n > 0
Backtrace:
../src/emacs(+0x226e87)[0x5e2f8ba24e87]
../src/emacs(+0x6047d)[0x5e2f8b85e47d]
../src/emacs(+0x34a2ac)[0x5e2f8bb482ac]
../src/emacs(+0x34bd88)[0x5e2f8bb49d88]
../src/emacs(+0x34d968)[0x5e2f8bb4b968]
../src/emacs(+0x3128c6)[0x5e2f8bb108c6]
../src/emacs(+0x312fd1)[0x5e2f8bb10fd1]
../src/emacs(+0x2a9bec)[0x5e2f8baa7bec]
/home/andcor03/emacs4/native-lisp/30.0.50-74ae6c6c/comp-7672a6ed-f5e09f0c.eln(F636f6d702d2d6e61746976652d636f6d70696c65_comp__native_compile_0+0xb39)[0x7e83c178fcd9]
../src/emacs(+0x2a9bec)[0x5e2f8baa7bec]
/home/andcor03/emacs4/native-lisp/30.0.50-74ae6c6c/comp-7672a6ed-f5e09f0c.eln(F636f6d702d7472616d706f6c696e652d636f6d70696c65_comp_trampoline_compile_0+0x232)[0x7e83c178e522]
../src/emacs(+0x2a9bec)[0x5e2f8baa7bec]
/home/andcor03/emacs4/native-lisp/30.0.50-74ae6c6c/comp-run-a15747ee-f15895e9.eln(F636f6d702d737562722d7472616d706f6c696e652d696e7374616c6c_comp_subr_trampoline_install_0+0x1e7)[0x7e83c17160d7]
../src/emacs(+0x2a9bec)[0x5e2f8baa7bec]
../src/emacs(+0x28d7c5)[0x5e2f8ba8b7c5]
../src/emacs(+0x3060ef)[0x5e2f8bb040ef]
../src/emacs(+0x2a9bec)[0x5e2f8baa7bec]
/home/andcor03/emacs4/src/../native-lisp/30.0.50-74ae6c6c/preloaded/nadvice-64630aaa-9efa993d.eln(F6164766963652d2d6164642d66756e6374696f6e_advice__add_function_0+0x217)[0x7e83c1a331e7]
../src/emacs(+0x2a9bec)[0x5e2f8baa7bec]
/home/andcor03/emacs4/src/../native-lisp/30.0.50-74ae6c6c/preloaded/nadvice-64630aaa-9efa993d.eln(F6164766963652d616464_advice_add_0+0x19e)[0x7e83c1a3462e]
../src/emacs(+0x2ae310)[0x5e2f8baac310]
../src/emacs(+0x2ae6b4)[0x5e2f8baac6b4]
[...]

  Andrea