[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Declaring Lisp function types
From: |
Andrea Corallo |
Subject: |
Re: Declaring Lisp function types |
Date: |
Thu, 02 May 2024 11:18:03 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Andrea Corallo <acorallo@gnu.org>
>> Cc: emacs-devel@gnu.org, stefankangas@gmail.com, adam@alphapapa.net,
>> monnier@iro.umontreal.ca, arthur.miller@live.com
>> Date: Wed, 01 May 2024 16:54:04 -0400
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > Without any discussion of what can be @var{type} and no examples, this
>> > is too abstract. I learned more about it from the other parts of the
>> > changeset, where you actually use this. So please say something about
>> > what can be @var{type}, and add one or two examples.
>> >
>> > Also, should we say something in NEWS about this?
>>
>> Entry added.
>>
>> Please let me know if you like me to merge it or I can improve it
>> further.
>
> Thanks. I still have a few minor comments below, but we can handle
> these after this lands on master.
Hi Eli,
I've addressed your suggestions (hope I'm not missing something) and
pushed the merge to master.
Happy to improve it (or see it improved) further there if necessary.
I just left this out:
> Suggest to reword:
>
> It is now possible to declare the expected type of a function's
> arguments using the 'declare' macro.
as is not just about input arguments but also return type.
Andrea
PS thanks for the review, it has improved my texinfo skills 😀🚀.