[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-29 b54febef5d7: Fix NetBSD build with and without ncurses
From: |
Eli Zaretskii |
Subject: |
Re: emacs-29 b54febef5d7: Fix NetBSD build with and without ncurses |
Date: |
Sun, 16 Jul 2023 13:31:41 +0300 |
> From: Po Lu <luangruo@yahoo.com>
> Cc: Valtteri Vuorikoski <vuori@notcom.org>
> Date: Sun, 16 Jul 2023 18:02:44 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > - if test "x$LIBS_TERMCAP" != "x-lterminfo"; then
> > + # NetBSD versions prior to 6.0 lack native terminfo, but have a
> > + # tputs() built on top of termcap in these libraries. Use native
> > + # termcap instead in this case. NetBSD >= 6.0 has native terminfo
> > + # implementation in -lterminfo.
> > + if test "x$LIBS_TERMCAP" = "x-ltermcap" -o "x$LIBS_TERMCAP" =
> > "x-lcurses"; then
>
> >From (autoconf)Portable Shell:
>
> The `-a', `-o', `(', and `)' operands are not present in all
> implementations, and have been marked obsolete by Posix 2008. This
> is because there are inherent ambiguities in using them. For
> example, `test "$1" -a "$2"' looks like a binary operator to check
> whether two strings are both non-empty, but if `$1' is the literal
> `!', then some implementations of `test'' treat it as a negation of
> the unary operator `-a'.
We use -o in other places with 'test'. So this is evidently not a
problem.
> Will anyone object if I change this to:
>
> AS_IF([test "x$LIBS_TERMCAP" != "x-lterminfo" \
> || test "x$LIBS_TERMCAP" = "x-lcurses"],
> [...])
>
> on the release branch?
Please don't.