[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last ch
From: |
Ruijie Yu |
Subject: |
Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change. |
Date: |
Wed, 10 May 2023 23:02:31 +0800 |
User-agent: |
mu4e 1.11.3; emacs 30.0.50 |
Philip Kaludercic <philipk@posteo.net> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> OK, then this is my proposal:
>
> I noticed a bug, here is a revised version:
>
> - (cond ((member status '("installed" "dependency" "unsigned"
> "external"))
> + (cond ((member status (append
> + '("installed" "dependency" "unsigned"
> "external" "built-in")
> + (and package-install-upgrade-built-in
> '("built-in"))))
I'm having a hard time understanding the significance of this portion.
Why using (and ... '("built-in")) ? AFACT, it adds matching status with
"built-in", but unconditionally, because of the added element in the
literal list?
And since the result of `member' is unused (except for checking its
boolean value), whether it returns one or two copies of "built-in" would
make no difference either.
--
Best,
RY
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., (continued)
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Eli Zaretskii, 2023/05/08
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Philip Kaludercic, 2023/05/08
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Eli Zaretskii, 2023/05/08
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Philip Kaludercic, 2023/05/10
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Philip Kaludercic, 2023/05/10
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Eli Zaretskii, 2023/05/10
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change.,
Ruijie Yu <=
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Philip Kaludercic, 2023/05/11
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Dmitry Gutov, 2023/05/10
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Philip Kaludercic, 2023/05/11
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Dmitry Gutov, 2023/05/11
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Eli Zaretskii, 2023/05/11
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Philip Kaludercic, 2023/05/12
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Dmitry Gutov, 2023/05/07
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Eli Zaretskii, 2023/05/08
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Dmitry Gutov, 2023/05/08
- Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change., Eli Zaretskii, 2023/05/12