emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-29 b18754bb179: Minor improvements in c-ts-mode and docs


From: Eli Zaretskii
Subject: Re: emacs-29 b18754bb179: Minor improvements in c-ts-mode and docs
Date: Wed, 15 Feb 2023 21:37:51 +0200

> Date: Wed, 15 Feb 2023 20:50:30 +0200
> Cc: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
> From: Dmitry Gutov <dgutov@yandex.ru>
> 
> If M-; doesn't work adequately with transient-mark-mode off, it seems 
> like an area for improvement. E.g. like this:
> 
> diff --git a/lisp/newcomment.el b/lisp/newcomment.el
> index 022bf3059be..effa90371e5 100644
> --- a/lisp/newcomment.el
> +++ b/lisp/newcomment.el
> @@ -1364,7 +1364,8 @@ comment-dwim
>   You can configure `comment-style' to change the way regions are 
> commented."
>     (interactive "*P")
>     (comment-normalize-vars)
> -  (if (use-region-p)
> +  (if (or (not transient-mark-mode)
> +          (use-region-p))

This cannot be right: with it, it would be impossible to get M-; to
start a new comment when transient-mark-mode is off.

> I just don't see why C Mode needs that binding, whereas all other 
> language modes don't.

Maybe it's the other way around: all other languages need "C-c C-c".



reply via email to

[Prev in Thread] Current Thread [Next in Thread]