[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-29 dc78779c0c: Fix SVG scaling (bug#59802)
From: |
Eli Zaretskii |
Subject: |
Re: emacs-29 dc78779c0c: Fix SVG scaling (bug#59802) |
Date: |
Sat, 17 Dec 2022 10:25:47 +0200 |
> From: Po Lu <luangruo@yahoo.com>
> Cc: Manuel Giraud <manuel@ledu-giraud.fr>
> Date: Sat, 17 Dec 2022 09:26:08 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > + if (! (0 < viewbox_width) && (iwidth.unit == RSVG_UNIT_PERCENT))
> > + viewbox_width = (viewbox_height * viewbox.width / viewbox.height)
> > + * iwidth.length;
> > + else if (! (0 < viewbox_height) && (iheight.unit ==
> > RSVG_UNIT_PERCENT))
> > + viewbox_height = (viewbox_width * viewbox.height / viewbox.width)
> > + * iheight.length;
>
> Our style is to write:
>
> viewbox_width = ((viewbox_height * viewbox.width / viewbox.height)
> * iwidth.length);
>
> and not:
>
> viewbox_width = (viewbox_height * viewbox.width / viewbox.height)
> * iwidth.length;
There's nothing wrong with the original style, although I agree that
using extra parentheses makes it more plausible. There's no reason to
be so stringent in insisting on the other style.