emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: scratch/comp-static-data 39b19c9bbf 3/3: comp.c: Emit subrs as union


From: Po Lu
Subject: Re: scratch/comp-static-data 39b19c9bbf 3/3: comp.c: Emit subrs as union types.
Date: Mon, 21 Nov 2022 08:41:03 +0800
User-agent: Gnus/5.13 (Gnus v5.13)

Vibhav Pant <vibhavp@gmail.com> writes:

> branch: scratch/comp-static-data
> commit 39b19c9bbfcc2a2456cc7258bf7bb87fb890b555
> Author: Vibhav Pant <vibhavp@gmail.com>
> Commit: Vibhav Pant <vibhavp@gmail.com>
>
>     comp.c: Emit subrs as union types.
>     
>     Instead of declaring Lisp_Subr variables as Lisp_Vector, and then
>     assigning them their respective subr values by bitcasting them as
>     their subr_type, declare variables for storing Lisp_Subrs as a union
>     type of a Lisp_Subr and a Lisp_Vector. This lets us initialize the
>     constant parts of a subr at the beginning, only requiring the `comp_u'
>     field to be set at initialization in `comp_init_objs'.

You did not write the name of the function you changed in this commit
message either.  Please pay attention to how you write commit messages,
as cleaning up ChangeLog by hand prior to releases is a chore!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]