Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS

[Philip Kaludercic]

Jonas Bernoulli <jonas@bernoul.li> writes:

> I cannot find it now, but somewhere in this thread you discussed
> uninstalling a vc-installed package without risking to lose any
> local changes.

I suppose you mean <jwva64rhr91.fsf-monnier+emacs@gnu.org> and
<jwvy1sahlcf.fsf-monnier+emacs@gnu.org>.

> In Borg I handle it like this:
>
> Installing a package detaches the gitdir from the working tree.
> (Borg uses submodules, but you don't need to do that to detach the
> gitdir.)
>
> Uninstalling the package only removes the working tree.  Keeping the
> gitdir preserves all branches, stashes and dangling revs.  Uninstalling
> is only allowed if there are no uncommitted changes.
>
> The gitdir remains and if the user ever installs the same package again,
> they are at that time asked whether to simply restore the working tree
> or to start over and discard the existing gitdir.

>From what I see this relies on the advantage of fixing a VCS like Git,
while package-vc -- to stay VCS agnostic -- keeps everything within a
directory.  I think that Stefan's suggestion to double-check if a user
really wants to delete a VC package should be enough.