Re: feature/package-vc has been merged

[Philip Kaludercic]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: monnier@iro.umontreal.ca,  rms@gnu.org,  emacs-devel@gnu.org
>> Date: Mon, 07 Nov 2022 18:10:04 +0000
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > OK, but my question was why all of this gets magically done when you
>> > clone the repository outside ~/.emacs.d/elpa, but does not get done
>> > when you clone it inside?  I thought this is what you were alluding to
>> > when I asked why not clone into ~/.emacs.d.
>> 
>> Oh no, I'm sorry if I implied this somehow.  This is neither the case in
>> or outside of ~/.emacs.d/elpa.  Somehow, someone has to do all of this.
>> And one someone is package-vc.
>
> So my proposal is to clone the repositories below ~/.emacs.d/elpa/,
> and thus solve the problem of linking/copying of files from the
> repository to .emacs.d (and several others, which you and Stefan for
> some reason don't consider important enough).
>
> And with that, let me bow out of this, since I think you understand
> well enough what I proposed and can make your own decisions.

I have implemented the necessary changes, and it appears to work.  One
reservation I have is the following change:

--8<---------------cut here---------------start------------->8---
@@ -1090,17 +1096,19 @@ package-generate-autoloads
          (backup-inhibited t)
          (version-control 'never))
     (loaddefs-generate
-     pkg-dir output-file
-     nil
-     "(add-to-list 'load-path (directory-file-name
-                         (or (file-name-directory #$) (car load-path))))")
+     (file-name-concat pkg-dir lisp-dir)
+     output-file nil
+     (prin1-to-string
+      `(add-to-list 'load-path
+                    (directory-file-name
+                     ,(file-name-concat pkg-dir lisp-dir)))))
     (let ((buf (find-buffer-visiting output-file)))
       (when buf (kill-buffer buf)))
     auto-name))
--8<---------------cut here---------------end--------------->8---

Git tells me that Lars was wrote the "(or (file-name-directory #$) (car
load-path))" bit, so I've added him to the CC's: Can you explain what
the intention was here, and if my suggested replacement would break
anything?