Re: master ed84f24a21: Make `signal-process' allow completing over signal names

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> +DEFUN ("signal-names", Fsignal_names, Ssignal_names, 0, 0, 0,
> +       doc: /* Return a list of known signal names on this system.  */)
> +  (void)
> +{
> +  char name[SIG2STR_MAX];
> +  Lisp_Object names = Qnil;
> +  for (int i = 0; i < 255; ++i)
> +    {
> +      if (!sig2str (i, name))
> +     {
> +       names = Fcons (build_string (name), names);
> +     }
> +    }
> +  return names;
> +}
> +

Shouldn't the "255" be NSIG instead? And what about systems where POSIX
signal handling doesn't really apply, such as MS Windows and MS-DOS?

Thanks.