[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master a9b393c: Include development data in --version output
From: |
Eli Zaretskii |
Subject: |
Re: master a9b393c: Include development data in --version output |
Date: |
Thu, 02 Jun 2022 10:55:02 +0300 |
> Date: Wed, 01 Jun 2022 22:10:23 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> CC: emacs-devel@gnu.org
>
> I fixed the crash, but I cannot say that I'm happy with how this is
> implemented: it is not safe to call Lisp functions so early into the
> startup, before all the gazillion of init_FOO initializations were
> called and did their things. Look how the next Lisp function call is
> waaaay down the 'main', _after_ the initializations.
>
> I think this code fragment is a bomb waiting to go off.
And here it is, going off (on GNU/Linux):
$ make
$ ./src/temacs -version
GNU Emacs 29.0.50
Segmentation fault
> We should IMO instead raise a flag and then test it and act on it
> much later in the code.
Now done.