[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mailcap-add-mailcap-entry: Superfluous setcdr, readability,
From: |
Felix Dietrich |
Subject: |
Re: [PATCH] mailcap-add-mailcap-entry: Superfluous setcdr, readability, entry overriding |
Date: |
Sat, 19 Mar 2022 15:12:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Felix Dietrich <felix.dietrich@sperrhaken.name> writes:
>
>> The first, relating to readability: I found it quit difficult to follow
>> the flow of the functionʼs code due to its nesting and idiosyncratic
>> order of condition checking. I want to, therefore, propose a
>> restructured version, which I believe to be functionally equivalent.
>
> Yes, the code is pretty confusing... so reading the patches, I'm not
> quite sure whether the new one is equivalent or not. So I think we'd
> want to have a number of tests in mailcap-tests.el to test that the
> results really are equivalent before and after the change, too.
I have written a couple of test cases. Let me know if this is what you
had in mind.
0001-Add-tests-for-mailcap-add-mailcap-entry.patch
Description: Patch that adds tests for mailcap-add-mailcap-entry
--
Felix Dietrich
- [PATCH] mailcap-add-mailcap-entry: Superfluous setcdr, readability, entry overriding, Felix Dietrich, 2022/03/07
- Re: [PATCH] mailcap-add-mailcap-entry: Superfluous setcdr, readability, entry overriding, Lars Ingebrigtsen, 2022/03/09
- Re: [PATCH] mailcap-add-mailcap-entry: Superfluous setcdr, readability, entry overriding, Felix Dietrich, 2022/03/10
- Re: [PATCH] mailcap-add-mailcap-entry: Superfluous setcdr, readability, entry overriding,
Felix Dietrich <=
- Re: [PATCH] mailcap-add-mailcap-entry: Superfluous setcdr, readability, entry overriding, Lars Ingebrigtsen, 2022/03/20
- Re: [PATCH] mailcap-add-mailcap-entry: Superfluous setcdr, readability, entry overriding, Felix Dietrich, 2022/03/20
- Re: [PATCH] mailcap-add-mailcap-entry: Superfluous setcdr, readability, entry overriding, Lars Ingebrigtsen, 2022/03/21