[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master f62a6acd00: Better handle drag-and-drop from one Emacs frame
From: |
Po Lu |
Subject: |
Re: master f62a6acd00: Better handle drag-and-drop from one Emacs frame to another |
Date: |
Wed, 16 Mar 2022 19:21:12 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> One of these changes apparently leads to this warning:
>
> xterm.c: In function 'handle_one_xevent':
> xterm.c:959:29: warning: 'target_proto' may be used uninitialized in this
> function [-Wmaybe-uninitialized]
> 959 | msg.xclient.data.l[1] = (((unsigned int) min
> (X_DND_SUPPORTED_VERSION,
> xterm.c:11653:17: note: 'target_proto' was declared here
> 11653 | int target_proto;
> | ^~~~~~~~~~~~
>
> On Debian/bookworm.
diff --git a/src/xterm.c b/src/xterm.c
index 7d1a5f4043..46a22d8dc1 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -866,6 +866,7 @@ x_dnd_get_target_window (struct x_display_info *dpyinfo,
if (x_had_errors_p (dpyinfo->display) || !rc)
{
x_uncatch_errors_after_check ();
+ *proto_out = -1;
return None;
}
}
Does this help?
Thanks.