emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 68e293c81d: Fix reporting of imaginary key prefixes on toolki


From: Robert Pluim
Subject: Re: master 68e293c81d: Fix reporting of imaginary key prefixes on toolkit tool and menu bars
Date: Wed, 02 Mar 2022 15:00:18 +0100

>>>>> On Wed, 02 Mar 2022 21:40:35 +0800, Po Lu <luangruo@yahoo.com> said:

    Po> Robert Pluim <rpluim@gmail.com> writes:
    >> If the only purpose of menu_bar_p and tool_bar_p is to set an
    >> appropriate value for posn, then would it not be simpler to have the
    >> hook return the desired value directly?

    Po> It would be simpler, but this is going to be used in some other places
    Po> as well (to fix toolbar clicks not working after a passive grab on an
    Po> xwidget is released on top, for example.)

OK

    >> Also, Iʼd put the track_mouse if condition as the outer test, to avoid
    >> calling the hook when its value is not actually needed.

    Po> Sure thing, thanks.  I assumed it would be clearer this way since the
    Po> comment on top describes that test as a temporary solution.

If tax law in my country of residence is anything to go by, thereʼs
nothing more permanent than a temporary solution :-)

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]