Re: master d50e0bd 2/2: Use compiler macros for the key syntax checks

[Michael Albinus]

Mattias Engdegård <mattiase@savannah.gnu.org> writes:

Hi Mattias,

>     Use compiler macros for the key syntax checks
>     
>     Compile-time key string syntax checks are better written using
>     compiler macros than with byte-hunk-handlers inside the compiler
>     proper.
>     
>     * lisp/emacs-lisp/bytecomp.el (byte-compile-define-keymap)
>     (byte-compile-define-keymap--define): Remove.
>     * lisp/keymap.el (keymap--compile-check): New.
>     (keymap-set, keymap-global-set, keymap-local-set, keymap-global-unset)
>     (keymap-local-unset, keymap-unset, keymap-substitute)
>     (keymap-set-after, key-translate, keymap-lookup, keymap-local-lookup)
>     (keymap-global-lookup): Use compiler-macro for argument checks.
>     * lisp/subr.el (define-keymap--compile): New.
>     (define-keymap--define): Fold into define-keymap.
>     (define-keymap): Use compiler-macro.
>     (defvar-keymap): Use define-keymap.
> ---
>  lisp/emacs-lisp/bytecomp.el | 63 
> ---------------------------------------------
>  lisp/keymap.el              | 22 +++++++++++++++-
>  lisp/subr.el                | 30 +++++++++++++++++----
>  3 files changed, 46 insertions(+), 69 deletions(-)

This fails on emba:

--8<---------------cut here---------------start------------->8---
#12 1510. Loading emacs-lisp/byte-run (source)...
#12 1510. Loading emacs-lisp/backquote (source)...
#12 1510. Loading subr (source)...
#12 1510. Symbol's function definition is void: remq
#12 1510. make[2]: *** [bootstrap-emacs.pdmp] Error 255
#12 1510. Makefile:907: recipe for target 'bootstrap-emacs.pdmp' failed
#12 1510. make[2]: Leaving directory '/checkout/src'
#12 1510. make[1]: *** [src] Error 2
#12 1510. make: *** [bootstrap] Error 2
#12 1510. Makefile:452: recipe for target 'src' failed
#12 1510. make[1]: Leaving directory '/checkout'
#12 1510. Makefile:1159: recipe for target 'bootstrap' failed
#12 ERROR: executor failed running [/bin/sh -c make bootstrap]: exit code: 2
--8<---------------cut here---------------end--------------->8---

See also <https://emba.gnu.org/emacs/emacs/-/jobs/34063/raw>.

Best regards, Michael.