emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master ad442b8: Make all vc-*-responsible-p functions return a strin


From: Dmitry Gutov
Subject: Re: master ad442b8: Make all vc-*-responsible-p functions return a string
Date: Mon, 15 Nov 2021 16:21:24 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 14.11.2021 11:41, Lars Ingebrigtsen wrote:
Stefan Kangas<stefan@marxist.se>  writes:

I believe this broke a test:

1 unexpected results:
    FAILED  vc-test-cvs01-register
Yup.  Should be fixed now.

FWIW, -responsible-p is documented to return non-nil rather than a particular string, at the top of vc.el.

So it was the previous change that was (osensibly) broken, since we'd generally use vc-root-dir to fetch said strings.

But I suppose this is a good change if it removes the need to hit the disk twice. The description of 'responsible-p' needs to be updated, though. Perhaps also describe what values can be returned by backends which do not support 'root'.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]