emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master cff1702: Fix hanging wdired test


From: Robert Pluim
Subject: Re: master cff1702: Fix hanging wdired test
Date: Mon, 15 Nov 2021 12:14:08 +0100

>>>>> On Mon, 15 Nov 2021 03:45:15 -0500 (EST), stefankangas@gmail.com (Stefan 
>>>>> Kangas) said:
    Stefan> @@ -148,11 +145,12 @@ wdired-get-filename before and after editing."
    Stefan>                (set-file-modes "foo" (file-modes-symbolic-to-number 
"+x"))
    Stefan>                (make-symbolic-link "foo" "bar")
    Stefan>                (make-directory "foodir")
    Stefan> -              (require 'dired-x)
    Stefan>                (dired-smart-shell-command "mkfifo foopipe")
    Stefan> -              (server-force-delete)
    Stefan> -              ;; FIXME?  This seems a heavy-handed way of making a 
socket.
    Stefan> -              (server-start)             ; Add a socket file.
    Stefan> +              (setq proc (make-network-process
    Stefan> +                          :name "foo"
    Stefan> +                          :family 'local
    Stefan> +                          :server t
    Stefan> +                          :service (expand-file-name "foosocket" 
test-dir)))

Not every platform supports local sockets, so you might want to
condition the socket on

   (featurep 'make-network-process '(:family local)))

in there somewhere. (MS-Windows uses TCP sockets for `server-start',
so there will be no change on that platform anyway)

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]