[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add command to browse xwidget history

From: Robert Pluim
Subject: Re: Add command to browse xwidget history
Date: Mon, 15 Nov 2021 10:40:11 +0100

>>>>> On Mon, 15 Nov 2021 13:15:54 +0800, Po Lu <luangruo@yahoo.com> said:

    Po> +@findex xwidget-webkit-browse-history
    Po> +@cindex history of webkit buffers
    Po> +  The command @code{xwidget-webkit-browse-history} displays a buffer
    Po> +containing a list of pages once loaded by the current WebKit buffer,

'previously loaded'

    Po> +and lets you navigate to those pages by hitting @kbd{RET}.
    Po> +
    Po> +It is bound to @kbd{H}.
    Po> +
    Po>  @node Browse-URL
    Po>  @subsection  Following URLs
    Po>  @cindex World Wide Web
    Po> diff --git a/etc/NEWS b/etc/NEWS
    Po> index 312fc18f4f..cda29650c0 100644
    Po> --- a/etc/NEWS
    Po> +++ b/etc/NEWS
    Po> @@ -486,6 +486,12 @@ This mode acts similarly to incremental search, 
and allows to search
    Po>  the contents of a WebKit widget.  In xwidget-webkit mode, it is bound
    Po>  to 'C-s' and 'C-r'.
    Po> ++++
    Po> +*** New command 'xwidget-webkit-browse-history'.
    Po> +This command displays a buffer containing the page load history of
    Po> +the current WebKit widget, and allows you to navigate to various
    Po> +points in history.
    Po> +

Short phrases are better: 'allows you to navigate it'

    Po> +               (when (get-buffer "*Xwidget WebKit History*")
    Po> +                 (with-current-buffer "*Xwidget WebKit History*"
    Po> +                   (revert-buffer)))

Minor optimisation: use `when-let'. Avoid repetition. DRY 😄


reply via email to

[Prev in Thread] Current Thread [Next in Thread]