Re: New function for explictly killing xwidgets

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Po Lu <luangruo@yahoo.com>
>> Date: Sun, 14 Nov 2021 13:04:54 +0800
>> 
>> * doc/lispref/display.texi (Xwidgets): Document changes.
>
> This should say "Document 'kill-xwidget'."
>
>> +DEFUN ("kill-xwidget", Fkill_xwidget, Skill_xwidget,
>> +       1, 1, 0,
>> +       doc: /* Kill live xwidget XWIDGET.
>
> One of the two "xwidget"s is redundant.  Our style in these cases is
> like this:
>
>   Kill the specified XWIDGET.
>
>> +  if (!NILP (xw->script_callbacks))
>> +    for (ptrdiff_t idx = 0; idx < ASIZE (xw->script_callbacks); idx++)
>
> It is better to use braces around the for-loop, although strictly
> speaking they aren't needed here.  But the code reads easier with
> them.

Thanks, how does this look to you?

0001-Add-kill-xwidget.patch
Description: Text Data