[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Subject: [PATCH] * lisp/xwidget.el (xwidget-webkit-browse-url): Remo

From: Po Lu
Subject: Re: Subject: [PATCH] * lisp/xwidget.el (xwidget-webkit-browse-url): Remove space prefix of url.
Date: Sat, 13 Nov 2021 18:45:26 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux)

Eli Zaretskii <eliz@gnu.org> writes:

> I'd improve like this:
>     "Canonicalize incomplete URL using SEARCH-PREFIX if URL is a search query.
>   Canonicalization means:
>     - prepend a scheme (a.k.a. \"protocol\") if it's missing
>     - append a slash if it's missing
>     - if URL is a search query, prepend SEARCH-PREFIX and hexify special
>       characters using `url-hexify-string'
>   Optional arg LOCAL-REGEX, if non-nil, means don't treat URLs that
>   match the regex as queries even if they otherwise look like it."

I think "one" would make more sense here, thanks.

> Given the meaning of LOCAL-REGEX (if it is indeed described correctly
> above), I'd ask why its name is _LOCAL_-REGEX, not something like
> ADDRESS-REGEXP?  there's nothing "local" about such an address, is
> there?

Thanks, I derived the name of the argument from `eww-local-regex'.  But
`address-regexp' would indeed make more sense.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]