Re: master 396355f: Re-fix charset issues when yanking non-plain-text elements

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> The old code took the data-type from the value of the
> foreign-selection property, but now we disregard that.  Is that on
> purpose?

Yes.  That made even binary data (like images) be mis-decoded.

Perhaps the logic here should be changed altogether -- and make all the
backend selection functions do the decoding themselves (since the
Windows one does it).

>> +                    ;; Guess at the charset for types like text/html
>> +                    ;; -- it can be anything, and different
>> +                    ;; applications use different encodings.
>> +                    ((string-match-p "\\`text/" (symbol-name data-type))
>> +                     (decode-coding-string
>> +                      data (car (detect-coding-string data))))
>
> Did you really need the explicit call to detect-coding-string?  AFAIR,
> decode-coding-string does that automatically if needed.  Did that fail
> in some case?

Can you give a nil to decode-coding-string as the coding system?  It's
not documented.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no