[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master b811ad1: Improve behavior of 'electric-pair-mode' in 'cc-mode
Re: master b811ad1: Improve behavior of 'electric-pair-mode' in 'cc-mode'
Sat, 06 Nov 2021 18:39:31 +0100
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
Jim Porter <email@example.com> writes:
> I see this too, but as you say, it only happens with "make
> check-maybe" (or when running electric-tests.el manually *after* "make
> check-maybe"). I can't reproduce it otherwise. If I check out the
> commit before this patch, the issue goes away though.
I see it if some parts of the Emacs source changes -- then check-maybe
reports a failure. But it goes away after a full check. But doesn't
come back if I say check-maybe and electric-tests. :-/
> I'm not totally clear on what check-maybe does, but it seems to create
> some persistent state that causes the electric-tests to fail.
Yes, it must be doing that, but I'm also vague on what it actually does.
Is there anybody with any insights here?
> The failure I see is in `whitespace-chomping-dont-cross-comments' for
> `c-mode', which would seem to point to my patch being the culprit, but
> if I'm understanding what that function is testing, everything works
> as it should when I try it out interactively.
Yes, I'm not seeing any issues either when testing interactively.
The electric tests are quite involved -- I've added João to the CCs.
Perhaps there's something extra that has to be done here for those.
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no