[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pcase.el: Add cl-type and type patterns

From: Eli Zaretskii
Subject: Re: [PATCH] pcase.el: Add cl-type and type patterns
Date: Sun, 11 Jul 2021 09:11:17 +0300

> From: Adam Porter <adam@alphapapa.net>
> Date: Sat, 10 Jul 2021 21:12:41 -0500
> It seems inevitable that I discover a mistake after posting a new patch
> series.  :)  I corrected a mistake in the NEWS file.  Please see these
> new patches.

A couple of comments about the documentation parts below.  I'll leave
the main part to other reviewers.

> +@item (cl-type @var{type})
> +Matches if @var{expval} is of type @var{type}, which is a symbol or
> +list as accepted by @ref{cl-typep,,,cl,Common Lisp Extensions}.

Please don't use @ref with this "HTML-style", it produces bad results
in Info.  Instead, use a slightly more wordy

  ... as accepted by @code{cl-typep} (@pxref{cl-typep,,,cl,Common Lisp

> +Example: @code{(cl-type integer)}
> +Example: @code{(cl-type (integer 0 10))}

Examples should be in a @lisp..@end lisp block, and then you can drop
the @code markup, which is applied automatically.

> +*** Added Pcase 'cl-type' pattern.
"pcase", without capitalization.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]