Re: master 3665735: Sort the items in 'mode-line-mode-menu' before displaying the menu

[Jim Porter]

On 6/24/2021 9:22 AM, Eli Zaretskii wrote:
> >   (defvar mode-line-major-mode-keymap
> >     (let ((map (make-sparse-keymap)))
> >       (bindings--define-key map [mode-line down-mouse-1]
> >         `(menu-item "Menu Bar" ignore
> >           :filter ,(lambda (_) (mouse-menu-major-mode-map))))
> >       (define-key map [mode-line mouse-2] 'describe-mode)
> > -    (define-key map [mode-line down-mouse-3] mode-line-mode-menu)
> > +    (bindings--define-key map [mode-line down-mouse-3]
> > +      `(menu-item "Menu Bar" ,mode-line-mode-menu
> > +        :filter bindings--sort-keymap))
> >       map) "\
> >   Keymap to display on major mode.")
> >   
> >   (defvar mode-line-minor-mode-keymap
> > -  (let ((map (make-sparse-keymap)))
> > +  (let ((map (make-sparse-keymap))
> > +        (mode-menu-binding
> > +         `(menu-item "Menu Bar" ,mode-line-mode-menu
> > +           :filter bindings--sort-keymap)))
> >       (define-key map [mode-line down-mouse-1] 'mouse-minor-mode-menu)
>
> Why does this use "Menu Bar" as the first arg of menu-item?

Just a paste-o, I'm afraid. They could probably be renamed to "Minor 
Modes", assuming I'm understanding how that string is used.

- Jim