Re: scratch/ns/refactor 06d9e72 5/6: Move NS port toolbar handling to the window

[Robert Pluim]

>>>>> On Wed, 23 Jun 2021 17:06:12 +0100, Alan Third <alan@idiocy.org> said:

    Alan> On Wed, Jun 23, 2021 at 04:57:34PM +0200, Robert Pluim wrote:
    >> >>>>> On Wed, 23 Jun 2021 15:27:42 +0100, Alan Third <alan@idiocy.org> 
said:
    >> >> The second frame has the tool-bar disabled, but unlike master the
    >> >> frame height is greater than the initial frame, and the frame title is
    >> >> bigger as well, as if its height had not been adjusted after removing
    >> >> the tool-bar.
    >> 
    Alan> What's happening is that the toolbar is set to be visible, but it has
    Alan> nothing in it, so it shrinks to the toolbar's minimum height.
    >> 
    Alan> Can you please try the following, I think it should sort it:
    >> 
    >> Youʼre on a roll here Alan. That fixes it.

    Alan> I've pushed a fix if you want to give it a go.

    Alan> Plus another couple of patches which probably break something else.

I guess that using the menus being dodgy when displaying a
tramp-visited buffer is normal? Emacs appears to be busy-looping, I
can provide backtrace if you want.

I never use the menus, so itʼs not a big deal to me.

Robert
--