emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and,


From: Stefan Monnier
Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations
Date: Wed, 02 Jun 2021 09:48:04 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> I admit I don't know how long or painful the discussion was for all of you,
> but so far the only argument against doing what I suggest is performance,
> and it seems weak according to my measurements (which are the only
> ones I've seen).

All the arguments for or against other alternatives are/were
similarly weak.  Hence this bikeshedding.

The fact that you perceive the difference as very important is the
result of the bikeshedding effect, nothing more.
Or call it NIH, if you want.  The end result is the same: please move on.

We can revisit this decision in 5 or 10 years when we have more
experience with all those new completion-table features, if you want.
But for now, `group-function` is good enough as it is.

>> I highly doubt changing the API for `group-function` would make any
>> measurable difference in this respect since it's a pretty small part of
>> "the complicated minibuffer.el".
> They make a difference in the part I was trying to touch.

It's easy to write a local adapter which adapts the current calling
convention to the one you propose or vice-versa, so the API itself can't
be the real reason for a significant difference.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]