[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 85e1719 1/4: Add a new command `mailcap-view-file'
|
From: |
Lars Ingebrigtsen |
|
Subject: |
Re: master 85e1719 1/4: Add a new command `mailcap-view-file' |
|
Date: |
Wed, 02 Jun 2021 07:33:37 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> What if mailcap-mime-info returns a function?
Right; that should be fixed.
>> + (mailcap-extension-to-mime (file-name-extension file)))))
>
> Is this the same as mailcap-file-name-to-mime-type?
Looks like it.
> Should any of this function's logic be shared with mailcap-view-mime?
I think so. By the way, that function looks somewhat unsafe?
(defun mailcap--async-shell (command file)
...
(async-shell-command (format command file) buf)
No quoting of the file name?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no