[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and,
From: |
João Távora |
Subject: |
Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations |
Date: |
Tue, 01 Jun 2021 13:00:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Daniel Mendler <mail@daniel-mendler.de> writes:
> On 6/1/21 11:56 AM, João Távora wrote:
>>> From my side the changes in your icomplete-vertical-mode-improvements
>>> branch are fine.
>>
>> I didn't get a terrible amount of feedback, but I spent the week testing
>> that branch, making small adjustments, and verifying that the default
>> Icomplete and Fido behaviour are unchanged. So I've now pushed the
>> icomplete-vertical-mode rework to master. I quite like it, to be
>> honest. I also added little filtered/total indicator idea found in
>> Vertico and many other completers.
>>
>> Here's a gif showing how to use it with Fido, my preferred option. To
>> try it out, just M-x fido-mode and M-x fido-vertical-mode together.
>
> Thanks! I just gave it another try. It looks good and feels similar to
> my Vertico. It works also well with Marginalia.
>
> * I observed an issue with the last candidate with `icomplete-scroll=t`
> - The candidate is one line off the minibuffer screen.
Hmm, I don't see that problem. Are you sure you're using the version in
master? Else you may be seeing a bug that was in
scratch/icomplete-vertical-mode-improvements (which should now be
scratched, as the name implies).
> * Is it possible to disable the index/count indicator? In Vertico I use
> `vertico-count-format` for that, if nil, the indicator is disabled.
I normally don't add a knob for things until someone actually requests
it. If you're requesting it, then it can be added (and you can too).
> * Do you plan to add more scroll commands, scroll forward/backward by
> one page as Vertico has it? See
> https://github.com/minad/vertico#key-bindings for the Vertico
> keybindings.
Could be added, yes.
> * Do you plan to support the `group-function`?
Maybe, but nothing in Emacs uses it so I can't test. You can add it
too, of course. I don't understand one thing about that protocol: why
the extra TRANSFORM argument flag? Why not just have that function
return a tuple with the group title and transformed name?
João
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, João Távora, 2021/06/01
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, Daniel Mendler, 2021/06/01
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations,
João Távora <=
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, Daniel Mendler, 2021/06/01
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, João Távora, 2021/06/01
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, Daniel Mendler, 2021/06/01
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, João Távora, 2021/06/01
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, Daniel Mendler, 2021/06/01
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, João Távora, 2021/06/01
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, Daniel Mendler, 2021/06/01
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, João Távora, 2021/06/01
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, Stefan Monnier, 2021/06/01
- Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations, João Távora, 2021/06/01