Re: Proposal for an improved `help-for-help'

[Stefan Kangas]

Stefan Kangas <stefan@marxist.se> writes:

> So does that mean that the below diff correct?  And is there a need to
> handle `PageDown' and `PageUp' in addition to `next' and `prior'?

No replies here, so I have now pushed the below change to master
(commit 04266a2cac).

If this leads to any problems, please reply here or report a bug and put
me on Cc.

> diff --git a/lisp/help-macro.el b/lisp/help-macro.el
> index 6a0e11574c..663b14d3d1 100644
> --- a/lisp/help-macro.el
> +++ b/lisp/help-macro.el
> @@ -174,9 +174,9 @@ make-help-screen
>                                               (point-max))
>                                              ""
>                                            (concat  ", or "
> -                                                   
> (help--key-description-fontified "\s") ; SPC
> +                                                   
> (help--key-description-fontified (kbd "<PageDown>"))
>                                                     " or "
> -                                                   
> (help--key-description-fontified "\d") ; DEL
> +                                                   
> (help--key-description-fontified (kbd "<PageUp>"))
>                                                     " to scroll"))))
>                             char (aref key 0)))
>
> diff --git a/lisp/help.el b/lisp/help.el
> index e143501081..8d6279de8f 100644
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -232,9 +232,9 @@ 'help
>    (purecopy "Type a help option: [abcCdefFgiIkKlLmnprstvw.] C-[cdefmnoptw] 
> or ?")
>    (concat
>     "\(Type "
> -   (help--key-description-fontified "\s") ; SPC
> +   (help--key-description-fontified (kbd "<PageDown>"))
>     " or "
> -   (help--key-description-fontified "\d") ; DEL
> +   (help--key-description-fontified (kbd "<PageUp>"))
>     " to scroll, "
>     (help--key-description-fontified "\C-s")
>     " to search, or \\<help-map>\\[help-quit] to exit.)"