Re: [PATCH] icomplete-vertical

[Gregory Heytings]

> > Do you really think it is better to ask users to set five options in 
> > their init file (icomplete-separator, icomplete-hide-common-prefix, 
> > icomplete-prospects-height, icomplete-minibuffer-setup-hook and 
> > icomplete-completions-filter-hook) instead of providing them right away 
> > with what they want with (icomplete-vertical-mode 1)?
>
> No, I think it would be better to have one user option like 
> icomplete-presentation set to 'vertical or something like that.

As I said, it's meant to be a derived minor mode, much like lisp-data-mode 
is derived from prog-mode.  A similar example (in the same file) is 
fido-mode which is derived from icomplete-mode, and (in another file) 
whitespace-newline-mode which is derived from whitespace-mode.

Moreover, I think that in general local changes to code are better than 
global ones whenever that is feasible.  Using a user option would do the 
same thing as the minor mode, except that the changes would be scattered 
through the existing code.