[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp def
From: |
Stefan Monnier |
Subject: |
Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) |
Date: |
Fri, 26 Mar 2021 12:32:32 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
>>> What's the performance impact here? This is going to be called a whole
>>> bunch of times when the user hits TAB...
>> It should be OK to do the condition-case wrapping around the loop rather
>> than within it, so the performance impact should be negligible.
> "Around the loop" means "around completing-read",
Not necessarily, e.g.
Stefan
diff --git a/lisp/simple.el b/lisp/simple.el
index 959bd83117..91069aa02a 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -1982,7 +1982,8 @@ read-extended-command
(concat (cond
((eq current-prefix-arg '-) "- ")
((and (consp current-prefix-arg)
- (eq (car current-prefix-arg) 4)) "C-u ")
+ (eq (car current-prefix-arg) 4))
+ "C-u ")
((and (consp current-prefix-arg)
(integerp (car current-prefix-arg)))
(format "%d " (car current-prefix-arg)))
@@ -1998,11 +1999,12 @@ read-extended-command
"M-X "
"M-x "))
(lambda (string pred action)
- (if (and suggest-key-bindings (eq action 'metadata))
- '(metadata
- (affixation-function . read-extended-command--affixation)
- (category . command))
- (complete-with-action action obarray string pred)))
+ (with-demoted-errors "Completion error: %S"
+ (if (and suggest-key-bindings (eq action 'metadata))
+ '(metadata
+ (affixation-function . read-extended-command--affixation)
+ (category . command))
+ (complete-with-action action obarray string pred))))
(lambda (sym)
(and (commandp sym)
(or (null read-extended-command-predicate)
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), (continued)
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Basil L. Contovounesios, 2021/03/26
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Stefan Monnier, 2021/03/26
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Basil L. Contovounesios, 2021/03/26
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Lars Ingebrigtsen, 2021/03/26
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Basil L. Contovounesios, 2021/03/26
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Basil L. Contovounesios, 2021/03/26
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063),
Stefan Monnier <=
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Basil L. Contovounesios, 2021/03/26
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Basil L. Contovounesios, 2021/03/26
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Lars Ingebrigtsen, 2021/03/26
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Basil L. Contovounesios, 2021/03/26
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Lars Ingebrigtsen, 2021/03/27
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Basil L. Contovounesios, 2021/03/27
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Stefan Monnier, 2021/03/14
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Michael Albinus, 2021/03/14
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Stefan Monnier, 2021/03/14
- Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063), Michael Albinus, 2021/03/15