[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsol
|
From: |
Eli Zaretskii |
|
Subject: |
Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsolete comment. |
|
Date: |
Mon, 09 Nov 2020 21:46:32 +0200 |
> Date: Mon, 09 Nov 2020 21:38:37 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: phst@google.com, emacs-devel@gnu.org
>
> > - ;; Due to limitations on Emacs integer values, faces with
> > - ;; face id greater than 512 are silently ignored.
> > (if (not face)
> > char
> > (let ((fid (face-id face)))
>
> Is this comment really obsolete? We still need to be able to pack a
> face ID and a 22-bit character codepoint into a single fixnum, which
> could be a 32-bit data type. See GLYPH_CODE_CHAR, GLYPH_CODE_FACE,
> and SET_GLYPH_FROM_GLYPH_CODE on dispextern.h.
Sorry, ignore me.