[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Support "\n" in icomplete-separator
From: |
Andrii Kolomoiets |
Subject: |
Re: [PATCH] Support "\n" in icomplete-separator |
Date: |
Sun, 08 Nov 2020 22:14:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) |
Ergus <spacibba@aol.com> writes:
I've checked your receipts on nearly recent master with the patch
applied on GTK3 build under Gnome and on NS build.
>> I propose use the 'icomplete-prospects-height' value as the count of
>> completions that must be shown.
>>
> Yes, I understand that; actually the height calculation was made because
> of this:
>
> (defface vmacs-minibuffer-font
> `((t :inherit default :height 1.3))
>
> Up to some months ago the pixel calculation was required because showing
> more candidates than fit in the minibuffer hided the prompt. There were
> long discussions related with that.
With changed minibuffer font size the prompt is visible.
>>> multiple \n in the separator
> This of course is supposed to work. But try with more candidates like 10
Prompt is still visible.
>>> display the completions in window-only frames like in mapple
>>
>> Thats actually why the patch was implemented. See,
>> maple-minibuffer-mode uses fixed frame height so the branch is show some
>> completions that fits based on frame-pixel-height. But mini-frame-mode,
>> which I use, uses resizeable minibuffer-only frame to show the
>> minibuffer content and the branch doesn't show any completions.
>> I mention this issue earlier:
>> https://lists.gnu.org/archive/html/emacs-devel/2020-11/msg00124.html
>>
>> In this usecase the patch behave better.
>>
> I can't reproduce the issue, that's why I didn't reply; sorry.
What build/OS you are using? I can reproduce it at least on NS and GTK3
builds. Doesn't minibuffer-only frame became the minimal width and
height for you right after evaluating '(setq resize-mini-frames t)'?
> In your use case I suppose it works "better" because the patch totally
> ignores the window height to fit; which, as I mention before, I am not
> sure is something we can do in the general case due to the prompt
> issue.
>
> If the prompt issue is totally away, we could; but I will need some
> confirmation from Eli or Stefan; but last time I tried it was still
> there.
I didn't saw the prompt issue. Stefan and Eli, can you please confirm
that the prompt issue is totally gone?
Thanks.
- [PATCH] Support "\n" in icomplete-separator, Andrii Kolomoiets, 2020/11/05
- Re: [PATCH] Support "\n" in icomplete-separator, Stefan Monnier, 2020/11/05
- Re: [PATCH] Support "\n" in icomplete-separator, Ergus, 2020/11/05
- Re: [PATCH] Support "\n" in icomplete-separator, Gregory Heytings, 2020/11/06
- Re: [PATCH] Support "\n" in icomplete-separator, Andrii Kolomoiets, 2020/11/06
- Re: [PATCH] Support "\n" in icomplete-separator, Eli Zaretskii, 2020/11/08
- Re: [PATCH] Support "\n" in icomplete-separator, Andrii Kolomoiets, 2020/11/09
- Re: [PATCH] Support "\n" in icomplete-separator, Eli Zaretskii, 2020/11/10
- Re: [PATCH] Support "\n" in icomplete-separator, Andrii Kolomoiets, 2020/11/10
- Re: [PATCH] Support "\n" in icomplete-separator, Gregory Heytings, 2020/11/10
- Re: [PATCH] Support "\n" in icomplete-separator, Andrii Kolomoiets, 2020/11/11
- Re: [PATCH] Support "\n" in icomplete-separator, Eli Zaretskii, 2020/11/10
- Re: [PATCH] Support "\n" in icomplete-separator, Gregory Heytings, 2020/11/10