emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 2a4b0da: Make minor mode ARG work as documented


From: Stefan Monnier
Subject: Re: master 2a4b0da: Make minor mode ARG work as documented
Date: Sun, 01 Nov 2020 10:33:24 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> +If called from Lisp, toggle the mode if if ARG is `toggle'.
> +Enable the mode if ARG is nil, omitted, or is a positive number.
> +All other values will disable the mode.

No: only non-positive numbers should be documented to disable the mode.
Other values should not be kept free for future use.

> +    (test-mode "what")
> +    (should (eq test-mode nil))))

This test is wrong, IMO.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]