Re: [PATCH] remove save and undo text on tool-bar for gtk version

[Caio Henrique]

Eli Zaretskii <eliz@gnu.org> writes:

> What about Lucid?
I never used the Lucid version before, but I could try it later when I
have some free time. I suppose that running configure with
"--with-x-toolkit=lucid" would allow me to build it, is that right?

I said that it only affects GTK because the documentation of
tool-bar-style says that "This variable only affects the GTK+ toolkit
version of Emacs.".

> Can you elaborate on the rationale for each change?  I don't think I
> have a clear idea of the reasons.
>
> Thanks.
These changes try to make the tool-bar more consistent since as it is
now, every other tool-bar item (new, open, close, cut, copy etc) on GTK
shows only the image [1], whereas the items "undo" and "save"" show both
the image and the text horizontally. Also, if I change the value of
tool-bar-style from nil to text-image-horiz, it doesn't do what it is
supposed to do, i.e. show bow the text and the image horizontally for
all items. All items that have :vertonly aren't affected by text-image-horiz.

This also saves horizontal space on the tool-bar, so we could add other
things like a "redo" buttom.

[1] I'm talking about the tool-bar items of fundamental-mode and
elisp-mode. The tool-bar for other modes like the GNUS tool-bar are also
inconsistent, here on GTK they show only the image for some items like
"previous unread", whereas other items like "next unread" show both the
icon and the text. IOW, the GNUS tool-bar doesn't even fit on the
default size of an Emacs frame. In other modes they behave differently,
e.g. here the tool-bar of custom mode show both the image and the text
horizontally for all the items, but they fit on the emacs frame unlike
the GNUS tool-bar. Option 1, making the default value 'image, would
solve all inconsistencies and every item would use only the
images. Thus, I think that option 1 is the better choice.