[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add some built-in faces for inheritance
From: |
Yuan Fu |
Subject: |
Re: Add some built-in faces for inheritance |
Date: |
Sat, 19 Sep 2020 16:00:38 -0400 |
> On Sep 19, 2020, at 3:50 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>> - foreground-highlight: highlight text using a different foreground color,
>> used for matched results, etc.
>
> Please don't rely too much on things like "color" in your descriptions.
> Think more of what is the intended use rather than the visual effect you
> expect for it.
Indeed.
> [ I for one likely wouldn't change the foreground color of "matched
> results". ]
>
> What kind of "matched results" are you thinking of?
> The text matched during isearch?
>
>> - background-highlight: highlighted text using a different background color,
>> used for selected candidate in company/ivy/helm, etc.
>
> I think this one could be an alias for the current `highlight`, right?
>
>
> Stefan
>
Maybe I should use “match-highlight”, and “selected-candidate”, respectively.
The problem is that “highlight” is a bit too board, there are many different
types of highlight: highlight of matched text during isearch, lazy-highlight
for isearch, highlight for current selection in company/ivy/helm, etc, etc. We
probably should make the definition more specific, so people know which one to
inherit from.
Yuan
- light, dark, and theme adjustment & generation [was: solarized], Drew Adams, 2020/09/17
- Re: Add some built-in faces for inheritance, Juri Linkov, 2020/09/20
- Re: Add some built-in faces for inheritance, Protesilaos Stavrou, 2020/09/21
- Re: Add some built-in faces for inheritance, Juri Linkov, 2020/09/21