[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbee
From: |
T.V Raman |
Subject: |
Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510 |
Date: |
Sun, 13 Sep 2020 08:27:32 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
eww-update-header-line was seeing the title as nil which is what
surprized me.
So: with the rendered buffer as current buffer, evaluating these in the
minibuffer:
(plist-get eww-data :title) returned the title I had set, but evaluating
(eww-update-header-line) in the minibuffer threw an error, with the
debugger showing that propertize had been called with a null string > "T.V
Raman" <raman@google.com> writes:
>
>> I'm setting eww-data correctly, and plist-get shows that :title is set
>> correctly in eww-data when I go to the buffer where the ebook is
>> rendered. However eww-update-header-line throws an error on this line:
>>
>> + (let ((title (propertize (plist-get eww-data :title)
>>
>> appears that plist-get in the above call returns nil within
>> eww-update-header-line --not sure why
>
> If that bugs out, then :title in eww-data can't be a string, I think?
>
> But I see that the old code supported a nil value for title, so I've now
> tweaked the code a bit to avoid bugging out in this case. Pushed to the
> trunk now.
--
?7?4 Id: kg:/m/0285kf1 ?0?8
- eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510, T.V Raman, 2020/09/13
- Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510, Lars Ingebrigtsen, 2020/09/13
- Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510,
T.V Raman <=
- Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510, T.V Raman, 2020/09/13
- Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510, Lars Ingebrigtsen, 2020/09/13
- Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510, T.V Raman, 2020/09/13
- Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510, Lars Ingebrigtsen, 2020/09/13
- Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510, Lars Ingebrigtsen, 2020/09/13
- Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510, T.V Raman, 2020/09/13