Re: 26.1: calc-mode header line [PATCH]

[Boruch Baum]

On 2020-09-05 09:57, Eli Zaretskii wrote:
> > Date: Mon, 31 Aug 2020 14:44:45 -0400
> > From: Boruch Baum <boruch_baum@gmx.com>
> >
> > Back in version 21, emacs introduced a static 'header-line' that could
> > be inserted at the top of any buffer. Calc mode is one emacs package
> > that does not use it and could benefit from it, so the attached patch
> > offers that feature. The main benefit is that the 'calc trail' buffer
> > (what some greybeards from the mechanical age would remember as the
> > 'tape reel') no longer has its title line scroll off the visible
> > window. The patch also includes:
>
> Thanks, but it sounds like the change is backward-incompatible: the
> old code which sets up the heading line is completely deleted, and if
> calc-show-banner is nil, there's no heading line at all.
>
> Can we please make this change backward-compatible, i.e. have a way
> for users to get the previous behavior by setting calc-show-banner to
> the nil value?

OK, if you're certain that the current/prior behavior isn't itself a
bug, in that the user asks calc-show-banner to be nil but gets a banner
anyway.

> Or maybe make your changes conditioned by a new value of
> calc-show-banner, different from nil and t? Or maybe it's better to
> introduce a new option?

No need to clutter up with more options for something this trivial. If
your judgment is that the current behavior isn't a bug, let me know and
I'll just adjust the calc-show-banner-nil case to keep the current/prior
behavior.

> In any case, there should be a NEWS item about the new behavior.

Slow news day? Diff against this URL?

   https://git.savannah.gnu.org/cgit/emacs.git/plain/etc/NEWS

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0