[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Delete variables obsolete since Emacs 23

From: Richard Stallman
Subject: Re: Delete variables obsolete since Emacs 23
Date: Wed, 26 Aug 2020 22:51:21 -0400

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > My commit bc5da2c3fb does basically the following:

  > -    (help-setup-xref (list 'describe-symbols pattern) (interactive-p))
  > +    (help-setup-xref (list 'describe-symbols pattern)
  > +                 (called-interactively-p 'interactive))

That is not the recommend way to fix these calls.
called-interactively-p does not give the correct results in all
situations.  The right way is to make the optional argument.

Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]