[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs 27.1 Windows Binaries -- testing wanted

From: Eli Zaretskii
Subject: Re: Emacs 27.1 Windows Binaries -- testing wanted
Date: Sat, 22 Aug 2020 17:35:18 +0300

> Date: Sat, 22 Aug 2020 14:53:15 +0100
> From: phillip.lord@russet.org.uk
> Cc: emacs-devel@gnu.org
> > I don't understand why it must break, if you base it on
> > system-configuration-features, or on some new file, to be generated by
> > the build procedure.  Did you consider one of these alternatives?  If
> > yes, why did you reject them?
> I didn't consider it much. I cannot see how to go from this to something 
> I can test. Say, `system-configuration-features` lists "XPM", I cannot 
> turn that into something I could test.

You'd need a database of features like XPM vs tests to test each

This assumes we are talking about a general-purpose feature-testing
facility of the kind proposed by Stefan, which I'm no longer sure is
the case, see below.

> I could modify by test something like
> (ert-deftest
>    (skip-unless (string-match-p "XPM" system-configuration-features))
>    (should (image-type-available 'xpm))
> )

Yes, this would also be good.

> >> If I think back to the bugs with Emacs binary releases, this would 
> >> have
> >> stopped only a few: harfbuzz and svg failure in this release. It would
> >> not have prevented missing dependencies (I have missed all of 
> >> harfbuzz,
> >> lcms and libjansson till late in the day), nor the failed optimization
> >> or stripping.
> > 
> > I don't understand this, either.  If the dependencies of HarfBuzz are
> > not installed, then the HarfBuzz font backend will not be available,
> > and the way I suggested for testing its availability will tell you
> > HarfBuzz doesn't work, which is AFAIU what you wanted.  And the same
> > with any other DLLs: if their dependencies are not available, they
> > will fail to load when the feature test runs, and the test will fail.
> It would work if, when harfbuzz was installed w32-features was updated, 
> but not if it wasn't. As the harfbuzz merge didn't update build-deps.zh 
> which it arguable should have, then why would a test file be updated.

Then I don't understand what you said in the quoted part above: you
seemed to be saying that you could have detected the absence of
HarfBuzz, but not of its dependencies.  Which is why I wrote that
having HarfBuzz without the dependencies will cause loading HarfBuzz
to fail, and Emacs will think that HarfBuzz is not available.  It
doesn't matter whether the HarfBuzz DLL or its dependency DLLs are
missing: in both cases the HarfBuzz DLL will fail to load.

IOW, I thought you were describing the situation where w32-features
_was_ updated to add a test for HarfBuzz.  If not, then how could you
have discovered that the DLL itself is not in the bundle?

> >> > If the latter, I didn't see you describe how will that happen.  If the
> >> > former, it means a file in the distribution will depend on the details
> >> > of how you build the official binaries, which could be different from
> >> > what end-users do on their systems (those who build their own Emacs),
> >> > so the tests will fail for them, AFAIU.
> >> 
> >> That is true with all of our tests, I think.
> > 
> > No, our tests use skip-unless to avoid running tests that need
> > features or programs which are unavailable.
> > 
> >> json parsing is tested by make check and it will not work on msys2
> >> if the dependencies are not installed.
> > 
> > I didn't look into this, but if json testing fails instead of skipping
> > all the tests, that's a bug that should be fixed.
> I think you are correct about all of these. In either case, the tests 
> will not pass!

Skipping a test and failing a test is not the same.  You are looking
for failures: tests that should have succeeded, but didn't.

> > That's not what worries me.  What worries me is the fact that a file
> > distributed as part of the Lisp libraries will have its contents
> > depend on the last release you personally did, with whatever quirks
> > that required from the tests in that file.  It doesn't sound right to
> > me.
> Not sure I understand this. A lisp library with "w32-" in it's name will 
> have behaviour which reflects how the official binaries are supposed to 
> behave. If this worries you, as I say, I can add it to `data-directory' 
> instead. But, it has to be in the distribution.

I thought we were talking about a feature that could serve any end
user, including those who build their own Emacs, not just the person
who produces the official binaries.  If this is only about the
official binaries, then why does it have to be under lisp/?  Where you
build the binaries, you always have the admin/ directory, albeit not
in the distribution zip, so how can its being in admin/ be a problem
for you?  You should be able to invoke the test file from any
directory on your system, not just from the unpacked archive.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]