[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: whitespace-only changes

From: Stefan Monnier
Subject: Re: whitespace-only changes
Date: Fri, 21 Aug 2020 09:13:41 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> I am sure he knows what he's talking about, but it is unfortunate that
> we cannot fix bad indentation.  Can't we correct this problem somehow?

FWIW, I think it's OK to commit whitespace-only changes when they fix
a "serious" problem, e.g. when the indentation is confusing.

AFAIK in the sample suggested commit, none of the changes were "serious"
(there was even one reindentation where I happen to prefer the current
indentation (even though it doesn't match what our auto-indent code

> For instance, label whitespace changes clearly in the commit log, and
> change some tools to ignore them?

I don't think whitespace-only changes are justified often enough to
warrant all that work (there are many tools that would be affected).
More useful would be to make the tools aware of file where whitespace
changes are (mostly) not significant so they can auto-resolve
some conflicts.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]