[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 4d00db5 8/8: Remove compat code from comint.el

From: Lars Ingebrigtsen
Subject: Re: master 4d00db5 8/8: Remove compat code from comint.el
Date: Wed, 12 Aug 2020 13:03:09 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

>>  Return the (possibly newly created) process buffer."
>> -  (or (fboundp 'start-file-process)
>> -      (error "Multi-processing is not supported for this system"))


> Perhaps the code here and in the previous commit meant to check for
> (fboundp 'make-process) instead?  start-file-process may always be
> defined, but I don't recall all platforms supporting subprocesses.  Or
> is this check no longer deemed necessary?

Yeah, that makes more sense.  There was an equivalent check in
esh-proc.el that added a lot of code to the non-start-file-process case
that made me wonder, too.

I guess there's still platforms without subprocess support?  DOS?  Or is
that deprecated?  If so, this patch (and the esh-proc.el patch) should
be reverted and the checks changed.

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]